Extend SQL syntax for searchable encryption #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement searchable tokenization for PostgreSQL for text/binary protocols
Updated CHANGELOG_DEV.md file
Fixed licence comment
# Conflicts: # CHANGELOG_DEV.md
Added MySQL support
Extend SQL syntax for searchable tokenization
Extend syntax for searchable encryption to suport INSERT/UPDATE/DELETE
# Conflicts: # encryptor/searchable_query_filter.go
update CHANGELOG_DEV.md file
Lagovas
reviewed
Oct 3, 2022
| if err != nil { | ||
| t.Fatal(err) | ||
| testcases := []testcase{ | ||
| {Query: "SELECT data1 from test_table WHERE data1=$1"}, |
There was a problem hiding this comment.
can you add unit-tests for these cases but with value literals? to test it without prepared statements too.
Added unit test for searchable encryption extended syntax
Lagovas
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension syntax for searchable encryption to support INSERT/UPDATE/DELETE syntax as we did in PR with searchable tokenization
P.S. Also, during integration testing, I noticed that a lot of raw bytes were printed in the output. Changed the logging fields just to print
packet typeinstead of raw bytes slice.Checklist
with new changes